Update node to v18#4471
Merged
Merged
Conversation
julienw
force-pushed
the
update-node-v18
branch
2 times, most recently
from
bccdaaa to
c08bb20
Compare
julienw
force-pushed
the
update-node-v18
branch
from
c08bb20 to
5dc7622
Compare
Codecov ReportBase: 88.63% // Head: 88.63% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #4471 +/- ##
=======================================
Coverage 88.63% 88.63%
=======================================
Files 284 284
Lines 25536 25536
Branches 6865 6865
=======================================
Hits 22634 22634
Misses 2695 2695
Partials 207 207 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
canova
approved these changes
Feb 14, 2023
| # This needs the major version only (eg: 16) | ||
| - ps: Install-Product node $env:nodejs_version $env:platform | ||
| # This needs the major version only (eg: 18) | ||
| # - ps: Install-Product node $env:nodejs_version $env:platform |
Member
There was a problem hiding this comment.
I wonder how much slower it will be compared to the older one. Maybe we should think about using circleci for the windows builders indeed.
Contributor
Author
There was a problem hiding this comment.
It's not clear to me whether circleci would be faster :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.